Skip to content

Fix SNAP work requirement issues#8372

Merged
MaxGhenis merged 3 commits into
PolicyEngine:mainfrom
daphnehanse11:codex/snap-work-requirement-fixes
May 27, 2026
Merged

Fix SNAP work requirement issues#8372
MaxGhenis merged 3 commits into
PolicyEngine:mainfrom
daphnehanse11:codex/snap-work-requirement-fixes

Conversation

@daphnehanse11

Copy link
Copy Markdown
Collaborator

Summary

Closes #8139.
Closes #8297.

This is a scoped SNAP work-requirement fix that:

  • changes meets_snap_work_requirements so one non-compliant member no longer denies the entire SPM unit when another member meets the work requirements
  • adds is_snap_abawd_indian_exempt for the OBBBA ABAWD Indian, Urban Indian, and California Indian exception
  • applies the new Indian exemption only in the post-OBBBA/HR1 ABAWD path so pre-HR1 behavior is unchanged
  • removes the non-functional boolean error margins in the existing SPM-level SNAP work-requirement tests

This is intended as a clean replacement for the narrow #8139 part of #8148. It does not include #8148's SNAP unit-size or proration changes.

Validation

  • uv run python -m policyengine_core.scripts.policyengine_command test policyengine_us/tests/policy/baseline/gov/usda/snap/eligibility/work_requirements/meets_snap_work_requirements.yaml policyengine_us/tests/policy/baseline/gov/usda/snap/eligibility/work_requirements/meets_snap_abawd_work_requirements.yaml -c policyengine_us
    • 41 passed.
  • uv run python -m policyengine_core.scripts.policyengine_command test policyengine_us/tests/policy/baseline/gov/usda/snap -c policyengine_us
    • 306 passed.
  • uv run --extra dev ruff format .
  • uv run --extra dev ruff check .
  • uv run pytest policyengine_us/tests/test_parameter_files.py policyengine_us/tests/test_system_import.py -q
    • 9 passed.
  • git diff --check

@codecov

codecov Bot commented May 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (0a1a9e3) to head (d3d4fa7).
⚠️ Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #8372   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         7    +6     
  Lines           14       111   +97     
=========================================
+ Hits            14       111   +97     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@daphnehanse11 daphnehanse11 marked this pull request as ready for review May 25, 2026 17:52
@MaxGhenis MaxGhenis force-pushed the codex/snap-work-requirement-fixes branch from f4c6ec7 to d3d4fa7 Compare May 27, 2026 13:23

@MaxGhenis MaxGhenis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the SNAP work-requirement changes, rebased onto current main, ran the SNAP suite locally, and fresh full CI passed. Ready to merge.

@MaxGhenis MaxGhenis merged commit eb6ff02 into PolicyEngine:main May 27, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants